small issue with combine Tashkeel. about arabic-support-unity HOT 7 OPEN

I am not the author of the original RemoveTashkeel function, I just edited it to support combined Tashkeel.

from arabic-support-unity.

Can that help fix issue #27 by any chance?

from arabic-support-unity.

Can that help fix issue #27 by any chance?

I had an issue like that, and I think this one would fix it, can you try and let me know ?
:)

from arabic-support-unity.

The Dec19 update seems to have fixed it. Thanks for the time you've put into it MohHeader.

from arabic-support-unity.

@MohHeader I'm not exactly sure about what all of RemoveTashkeel is doing, but would using something like Unicode Normalization help?

I have a simple example of that here.

from arabic-support-unity.

@obahareth

RemoveTashkeel, doesn't completely removes it, but it do so as a temp state.
Then either to return it back, or not.

I think "Unicode Normalization", is what I am trying to achieve through Combine Tashkeel

Let me give you an example
if you have Fateha+Shadah ــَّــ then normal case the plugin will show them as a two separate shapes.
in some fonts, they will overlap.

the solution is easy, just replace them both with a 1 unicode shape that combine both.
the bug introduced here was due to wrong calculations when trying to return back the Tashkeel.

I tried the example you listed, it only removes the Tashkeel

from arabic-support-unity.

@MohHeader That sounds a lot like Precomposed characters, but I don't think that's possible with Arabic characters.

So RemoveTashkeel isn't actually removing it, it's finding the locations of each Tashkeel character?

from arabic-support-unity.