Giter Club home page Giter Club logo

Comments (1)

kofigumbs avatar kofigumbs commented on June 7, 2024

Oh, I hadn't heard of Ghostery, thanks for the links! I don't think that library is designed for use with client-side JS since your second link only describes use in worker JS (like Node, Electron, browser extensions). So I think Multi would need to implement support for the blocklist as opposed to using customJs.

I'm open to adding blocklist support, and I can implement it next time I spend some time on Multi. I can't guarantee when that would be though. If you're interested in contributing it yourself, you should be able to reuse most of the implementation from V2:

WKContentRuleListStore.default().compileContentRuleList(forIdentifier: "blocklist", encodedContentRuleList: Browser.blocklist) { (rules, error) in
rules.map { configuration.userContentController.add($0) }
self.webView.load(URLRequest(url: url))
}
}

The only implementation change is that I think blocklists should be a config value (under tabs) instead of distributing it with Multi itself. That way users can supply their own if needed. We can add Examples/ghostery.json as a recommended solution. For consistency, the blocklists config field should accept [URL] just like custom CSS/JS do:

delegate.tab.customJs.compactMap({ try? String(contentsOf: $0) }).map { js in

from multi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.