Giter Club home page Giter Club logo

Comments (18)

3lpsy avatar 3lpsy commented on June 23, 2024 2

@phanan Totally fair. F-Droid is probably the most popular alternative app store for android. All software on it is open source and the builds are generated by the F-droid team. If you run LineageOS, the most popular android alternative, you typically get most if not all your apps from F-droid. Unfortunately, I don't have much experience getting an app on F-droid but if I ever acquire the skills/knowledge necessary, I'll circle back and try to PR something. Thanks for taking a look :)

from player.

pabloscloud avatar pabloscloud commented on June 23, 2024 1

@phanan bruh

from player.

phanan avatar phanan commented on June 23, 2024 1

@bibo38 Thanks a lot! I've merged #87. Let me know if there's anything else I can help with.

from player.

bibo38 avatar bibo38 commented on June 23, 2024 1

@phanan Got some comments from a review on the F-Droid side. I've implemented these in #89 . Could you merge this and either force update the v2.0.2 tag or change the version to 2.0.3 and tag it with v2.0.3?

from player.

bibo38 avatar bibo38 commented on June 23, 2024 1

@phanan Thanks for merging, but the new tag version doesn't match the version in the apk (which should come from the pubspec.yaml) and F-Droid currently fails on this. Sorry for me not to mention this change that explicitly (the "change the version to 2.0.3" part). So maybe update it to 2.0.4 and tag it again or force update the 2.0.2 tag as it's currently F-Droid specific anyway.

from player.

bilogic avatar bilogic commented on June 23, 2024 1

thanks, then i think it's time i moved onto something else

from player.

pabloscloud avatar pabloscloud commented on June 23, 2024

Yes, please! 💙

from player.

phanan avatar phanan commented on June 23, 2024

I'll be bluntly honest here: I don't even know what F-Droid is, and the process looks much more complicated than I'm willing to handle (or have the time to). If you want to own this, I'm happy to help.

from player.

bibo38 avatar bibo38 commented on June 23, 2024

I've created a PR with the required additions for F-Droid (it's the recommended way to add them to the repository). Once it's merged, I'll create the Merge request for inclusion on the F-Droid side.

@phanan There are some minor tasks, that will be necessary for F-Droid:

  • Create a Git tag for every release (e.g. v2.0.2)
  • Update the .flutter submodule, if the code is updated to a newer Flutter version
  • And a nice to have: add a corresponding changelog file for every release (numbering is 4000 + versionCode, see the example in the PR)

from player.

bibo38 avatar bibo38 commented on June 23, 2024

@phanan Nice, thanks. The fdroid checkupdates call currently outputs an error, as the last tag references an older version. Could you tag the current HEAD commit with v2.0.2?

from player.

phanan avatar phanan commented on June 23, 2024

@bibo38 Done!

from player.

bibo38 avatar bibo38 commented on June 23, 2024

Inclusion Merge Request on the F-Droid side: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13208

from player.

bilogic avatar bilogic commented on June 23, 2024

I saw this still under review on gitlab, and have allowed APKs from unknown sources on my mobile.

But I wasn't able to install all 3 APKs, is this normal?

from player.

pabloscloud avatar pabloscloud commented on June 23, 2024

I saw this still under review on gitlab, and have allowed APKs from unknown sources on my mobile.

But I wasn't able to install all 3 APKs, is this normal?

Same, I tried installing it via Obtainium and that didn't work either. And in Android Studio I just got a bunch of errors probably due to incompatible dependencies.

from player.

bibo38 avatar bibo38 commented on June 23, 2024

I saw this still under review on gitlab, and have allowed APKs from unknown sources on my mobile.

But I wasn't able to install all 3 APKs, is this normal?

The apks are unsigned. You can only install signed apps on an Android device, see https://stackoverflow.com/questions/10930331/how-to-sign-an-already-compiled-apk

You probably want the 2019 version, as it's for ARM64 v8a, while 1019 is for ARM v7a and 4019 is for x64

from player.

bibo38 avatar bibo38 commented on June 23, 2024

Current state: By requet (c9a4383#r124979603), I've created a fork for the F-Droid build.

You can find it here: https://codeberg.org/bibo38/koelplayer

Be aware, that until this is merged into F-Droid, this is subjected to changes! I'm trying to set up reproducible builds, but currently failing.

from player.

bilogic avatar bilogic commented on June 23, 2024

thanks @bibo38, but I don't get it, if this issue is closed, does it mean F-droid side is ok? I still can't find koel in F-droid.

from player.

bibo38 avatar bibo38 commented on June 23, 2024

The issue was closed due to the commit message of @phanan , although it was just an improvement to try making the F-Droid build work: c9a4383

After setting up my fork, I was hinted that a fork would require me to change the App ID, Name (in all texts/translations) and Logo due to F-Droids Inclusion Policy.

This is currently too much of a burden for me to get this app included (and keep it updated). Therefore I'll stop working on the F-Droid inclusion of Koel.

from player.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.