Comments (3)
A quick fix would be adding a build parameters.
@koddsson What do you mean by this exactly?
For my usecase I think I don't want to see a new comment every run/build, but only if something changes in the result of the run/the comment being posted on the PR.
This would mean getting the last comment created by the bot and checking if that comment is the same as the one that's about to be posted. Looking at the GitHub API docs that seems relatively easy https://developer.github.com/v3/issues/comments/#list-comments-on-an-issue
The main issue I see with this is that there's no way to tag/identify comments except for the message and user. That would mean if the same bot is used for comments using travis-github-pr-but as well as for other comments (like coveralls) it would be kind of difficult to make sure the correct message is used to check. A relatively simple way to fix this might be to start the comment with travis-github-pr-bot
or something along those lines.
What do you think?
from travis-github-pr-bot.
Hey @simonvanderveldt! I'm busy this week but I wanted to drop in and let you know that I've seen this issue and the other one you filed and am setting a calendar entry to look at this next week!
from travis-github-pr-bot.
@koddsson Thanks for the heads up! And no hurries, it's not urgent :)
from travis-github-pr-bot.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from travis-github-pr-bot.