Change to use json parameter breaks on request < 2.4.2 about python-digitalocean HOT 9 CLOSED

requests 2.4.2 was only released on 2014-10-05 so I guess it needs to be supported.

requests.post(url, json=data)

is really just a shortcut for

requests.post(url, data=json.dumps(data), headers={"content-type": "text/javascript"))

or something pretty similar.

So to support older versions of requests we could change to that

Alternatively we could go back to using query parameters but just make sure to translate booleans properly. However I think JSON's better.

from python-digitalocean.

Is this a problem related to python-digital ocean dependency? If so, I may need to understand the bug that you are reporting and which version is fixing this... or alternatively, change the code to work properly with the latest version available. Can somebody help me in this process?

from python-digitalocean.

I am thinking about that, because if we have to support older versions, then we need another solution. What about avoid requests and use another library? What if you install the latest version using pip?

from python-digitalocean.

@andrewsomething By running the tests with the dockerfile I wrote, it seems working properly on ubuntu 14.04 with both python 2 and python 3... can you check? Probably it is just a question of mocking the requests...

from python-digitalocean.

Installing requests with pip will get the latest version, and I can confirm that it allows the tests to pass. I can also confirm the Docker image successfully runs the tests (great idea!).

The problem for me is that I distribute digitalocean-indicator as Debian package. As it's a GUI app, asking end users to use pip isn't great. I guess I can backport requests though...

from python-digitalocean.

What about a specific environment?

from python-digitalocean.

2.7.6 also it doesn't work, but works on 2.7.11

from python-digitalocean.

Same problem? Should we update the requirement?

from python-digitalocean.

working fine with 2.7.6,issue with 2.7.9.

from python-digitalocean.