Describe the bug When only specifying an ip address

More specific it crashes in this section: <div class="Box Box--c

Crash when not specifying a protocol about opendirectorydownloader HOT 5 CLOSED

4censord commented on June 18, 2024

Crash when not specifying a protocol

from opendirectorydownloader.

Comments (5)

KoalaBear84 commented on June 18, 2024 1

Released: https://github.com/KoalaBear84/OpenDirectoryDownloader/releases/tag/v2.3.0.1

from opendirectorydownloader.

4censord commented on June 18, 2024

More specific it crashes in this section:

OpenDirectoryDownloader/src/OpenDirectoryDownloader/Program.cs

Lines 122 to 130 in 5d0765f

 if (string.IsNullOrEmpty(openDirectoryIndexerSettings.Username) && string.IsNullOrEmpty(openDirectoryIndexerSettings.Password)) 

 { 

 if (Library.GetUriCredentials(new Uri(url), out string username, out string password)) 

 { 

 Console.WriteLine($"Using username '{username}' and password '{password}'"); 

 openDirectoryIndexerSettings.Username = username; 

 openDirectoryIndexerSettings.Password = password; 

 } 

 }

It tries to extract a username and password from the provided url
(127.0.0.1), and not the sanitized url that is created here

OpenDirectoryDownloader/src/OpenDirectoryDownloader/Program.cs

Lines 105 to 114 in 5d0765f

 Console.WriteLine($"URL specified: {url}"); 

 string newUrl = Library.FixUrl(url); 

 if (newUrl != url) 

 { 

 Console.WriteLine($"URL fixed : {newUrl}"); 

 } 

 openDirectoryIndexerSettings.Url = newUrl;

from opendirectorydownloader.

Chaphasilor commented on June 18, 2024

Hmm, it looks likes this function isn't returning false when it should be:

OpenDirectoryDownloader/src/OpenDirectoryDownloader/Library.cs

Lines 349 to 364 in 5d0765f

 public static bool GetUriCredentials(Uri uri, out string username, out string password) 

 { 

 username = null; 

 password = null; 

 if (uri.UserInfo?.Contains(':') == true) 

 { 

 string[] splitted = uri.UserInfo.Split(':'); 

 username = WebUtility.UrlDecode(splitted.First()); 

 password = WebUtility.UrlDecode(splitted.Last()); 

 return true; 

 } 

 return false; 

 }

The issue appeared after v2.1.0.0, I'm guessing right after it with this commit: 5f08d02#diff-28bad5a72dee380228016222e2442b1cc7bbd86b59e16653038c9b8fdce2b2be

from opendirectorydownloader.

4censord commented on June 18, 2024

I think the crash happens in the call to new Uri(url), an not the GetUriCredentials function.

Uri uri = new Uri(url); // <= crash here
if (Library.GetUriCredentials(uri, out string username, out string password))
{
	Console.WriteLine($"Using username '{username}' and password '{password}'");
	openDirectoryIndexerSettings.Username = username;
	openDirectoryIndexerSettings.Password = password;
}

from opendirectorydownloader.

KoalaBear84 commented on June 18, 2024

Thanks, I see I was not using the 'fixed' url. 👍

from opendirectorydownloader.

Crash when not specifying a protocol about opendirectorydownloader HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	if (string.IsNullOrEmpty(openDirectoryIndexerSettings.Username) && string.IsNullOrEmpty(openDirectoryIndexerSettings.Password))
	{
	if (Library.GetUriCredentials(new Uri(url), out string username, out string password))
	{
	Console.WriteLine($"Using username '{username}' and password '{password}'");
	openDirectoryIndexerSettings.Username = username;
	openDirectoryIndexerSettings.Password = password;
	}
	}

	Console.WriteLine($"URL specified: {url}");

	string newUrl = Library.FixUrl(url);

	if (newUrl != url)
	{
	Console.WriteLine($"URL fixed : {newUrl}");
	}

	openDirectoryIndexerSettings.Url = newUrl;

	public static bool GetUriCredentials(Uri uri, out string username, out string password)
	{
	username = null;
	password = null;

	if (uri.UserInfo?.Contains(':') == true)
	{
	string[] splitted = uri.UserInfo.Split(':');

	username = WebUtility.UrlDecode(splitted.First());
	password = WebUtility.UrlDecode(splitted.Last());
	return true;
	}

	return false;
	}