Giter Club home page Giter Club logo

Comments (5)

haoxins avatar haoxins commented on May 18, 2024

@jonathanong May I publish koa-mount@2 (Of course as dist-tag next)

from mount.

tejasmanohar avatar tejasmanohar commented on May 18, 2024

+1 from me. Looks fine, assuming next dist-tag.

from mount.

haoxins avatar haoxins commented on May 18, 2024

Since existing next branch has never been published, and according to koajs/koa#625, just close this for now.
I'm going to delete the existing promise based next branch.

from mount.

tejasmanohar avatar tejasmanohar commented on May 18, 2024

imo-

  • if there's already a working next branch and koa convert doesn't work for mount, i'd just publish this to npm
  • if koa convert does work for mount, ignore this. no point of converting to promise-based middleware

from mount.

nevercast avatar nevercast commented on May 18, 2024

Why was the branch decidedly deleted? Was it clutter?

Edit: Ahh I see it utilized promises instead of just async/await. Unfortunately that didn't affect me because Babel replaced async/await with Promises anyway, so they were one and the same. Implementation was compatible.

from mount.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.