throws error if `next` not defined about convert HOT 4 CLOSED

Thanks your suggestion but I think this (your example) is a bad use case of koa middleware.

1. It creates and converts koa middleware for every requests, which is unnecessary.
2. It's error-prone. There might be a bug in your example code.

In rbac.allow at https://github.com/yanickrochon/koa-rbac/blob/master/rbac.js#L115, it restricts permission by return and not calling yield next. In your example, next is just noop and user without permission will continue go through downstream.

from convert.

You are right - I forgot to update this snippet when I encountered that bug. Here is how i'm handling this now:

export async function organizationIdParam (id, ctx, next) {
  await convert(rbac.allow('read:organization', { organization: id }))(ctx, noop);
  if (ctx.status === 403) return;

  ctx.organization = await Organization.findById(id);
  await next();
}

from convert.

I would not recommend you to create middleware dynamically like this. It seems that your use case (inject id dynamically) has beyond the scope of that middleware. (I am not familiar with that middleware and I might be wrong).

Also, ctx.status === 403 is hacking. I would suggest you to do it in this way:

export function organizationIdParam (id, ctx, next) { // or `async function` if you want
  return convert.compose(
    rbac.allow('read:organization', { organization: id }),
    async function (ctx, next) {
      ctx.organization = await Organization.findById(id);
      await next();
    }
  )(ctx, next);
}

from convert.

Great, that makes sense. Thank you!

from convert.