Giter Club home page Giter Club logo

Comments (7)

haoxins avatar haoxins commented on May 5, 2024

koa@2 requires node@4+

from compose.

blakeembrey avatar blakeembrey commented on May 5, 2024

@coderhaoxin Would you consider making the changes to just koa-compose? It'd be a bummer to duplicate all the code when it'd be nice just to re-use this library for arbitrary (non-Koa specific) async middleware.

from compose.

haoxins avatar haoxins commented on May 5, 2024

Would you consider making the changes to just koa-compose?

@blakeembrey I don't know what you meant. :) 😒

from compose.

blakeembrey avatar blakeembrey commented on May 5, 2024

This module is koa-compose, not koa. Would you consider making the code here ES5 instead of ES6 so that node <= 0.12 can use it? I'd like to use the module without replicating it for my own uses.

from compose.

haoxins avatar haoxins commented on May 5, 2024

@jonathanong we need change for of to normal for loop!

Should we add node <= 0.12 to the travis ?

from compose.

blakeembrey avatar blakeembrey commented on May 5, 2024

Thanks! The only other piece is the const. I'd love if you could test down to 0.10 too.

from compose.

blakeembrey avatar blakeembrey commented on May 5, 2024

For reference, I want to use it for a HTTP request library (serviejs/popsicle#49) and have written a corresponding type definition (https://github.com/typed-typings/npm-koa-compose/blob/master/index.d.ts) in case you're interested in supporting TypeScript users in the module.

from compose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.