An error on onerror about bodyparser HOT 4 CLOSED

@felixsanz I think this is co-body's bug that don't catch the error thrown in inflation, and this will be fix in cojs/co-body#54, hope it won't break your code since I'll consider it as a bug fix.

from bodyparser.

because bodyparser's onerror only catch the error thrown when parse the body, so it won't(and shouldn't) catch inflation's error.

this is not related with bodyparser, but if you want to ignore this error, you can try

app.use(async (ctx, next) => {
  try {
    await next();
  } catch (err) {
    // your custom error handler
  }
});
app.use(bodyparser());
app.use(otherMiddleware());

from bodyparser.

The problem is the inflation lib:

  switch (encoding) {
  case 'gzip':
  case 'deflate':
    break
  case 'identity':
    return stream
  default:
    var err = new Error('Unsupported Content-Encoding: ' + encoding)
    err.status = 415
    throw err
  }

This code is what is causing an early return (the default case).

Why the bodyparser promise catch doesn't catch it?

from bodyparser.

I tried to fix it but too many magic libraries involved :( Can someone help please?

This is a workaround:

  app.use(async (ctx, next) => {
    try {
      return bodyParser({
        enableTypes: ['text'],
        extendTypes: {
          text: ['text/html'],
        },
      })(ctx, next)
    } catch (err) {
      return ctx.throw(new Error('foo'), 400)
    }
  })

from bodyparser.