ResultPager::get() can return string about php-github-api HOT 4 OPEN

I am getting the same and to add more information, the response that causes this bug is 500 Internal Server Error, the body of the response is empty.

from php-github-api.

@dangrous or @iwiznia do you have an example call that triggers this behaviour? I would expect that the ErrorPlugin would handle the server error response and throw an exception

from php-github-api.

It's not any specific request, I am seeing this error pop up "randomly" and if I retry the request, it succeeds. I think it happens whenever it could not contact to the GH servers, thus the 500 error does not contain any data.
The PR I submitted to you fixes the problem.

from php-github-api.

@acrobat - from what I see - there are cases (consistently) where GitHub returns 204 "No Content" i.e. https://api.github.com/repos/tomsausage/empty-public/contributors

E.g. in

        // in the (sometimes) valid case that there is no content e.g. getting contributors where there are none
        // GitHub seems not to return an empty array, but instead, no content at all
        if ($result === "" && $this->client->getLastResponse()->getStatusCode() === 204) {
            $result = [];
        }

I know there is an existing PR, perhaps checking for this use case specifically? (Might not be 100% of the issue but at least is reproducible.

Will add PR to show what I mean

from php-github-api.