Giter Club home page Giter Club logo

Comments (2)

mmarx avatar mmarx commented on May 27, 2024

3.4028235e38 looks (at least) suspiciously close to f32::MAX (due to rounding on parsing the float value, it might actually even be equal to it). We might want to discuss whether we want to allow non-integer increments at all, since there might also be issues with non-exactly representable values such as 0.1, which, over the run of a full column, might accumulate quite some inaccuracy.

from nemo.

monsterkrampe avatar monsterkrampe commented on May 27, 2024

Some checks for this are done during construction of the RLE column, i.e. it is checked that the original values can be constructed again using the increment stored in the RLE. If this is not possible then a new RLE "block" is added.
Inaccuracies may still occur in the get function since the increment is just multiplied by the target index here. This is also what causes the problem above.

After our last discussion I'm also wondering if we need a RLE for floating point numbers at all or if we just need to support u64 anyway (see #38). I will discuss this offline before trying to fix this bug.

from nemo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.