./hack/update-codegen.sh doesn't do anything about community HOT 9 CLOSED

Also, documenting the ^ above explanation somewhere would be good.

from community.

@Bisht13 sometimes it will write to the files and thus should retain that message but other times when adding a member that does not change those files it should suppress those messages and just say "No changes needed for peribolos/knative-*-OWNERS_ALIASES".

I made the requested changes and opened a PR ✨

from community.

If you're just adding yourself as a member, I don't think there should be any update to the aliases files (those would only update if you were being added as a reviewer / approver / etc.)

from community.

Hmmm, I heard that we do need to run it here.

from community.

There were no updates to the aliases files when you ran the script, which is expected when you're just adding yourself to the member list (see here for a similar request that was merged, and here for an example of the type of change that would cause an alias update).

The output of the script in this case is a bit misleading, saying that it wrote to the alias files when no change was actually made. Might be useful to update the script to say something like "no changes made" in this type of scenario...

from community.

/label "help wanted"

Can somebody add "help wanted" label to this ticket please? So that it shows up in https://clotributor.dev/search?project=knative

from community.

/assign @Bisht13

from community.

@aliok Just confirming, I need to print something like, no changes made, if the file is not being updated right?

from community.

@Bisht13 sometimes it will write to the files and thus should retain that message but other times when adding a member that does not change those files it should suppress those messages and just say "No changes needed for peribolos/knative-*-OWNERS_ALIASES".

from community.