Comments (9)
/milestone v0.1.0
from client.
@csantanapr: You must be a member of the knative/knative-milestone-maintainers github team to set the milestone.
In response to this:
/milestone v0.1.0
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from client.
What does this look like? I suggest:
# specifying value as millicore
$kn service create --cpu-requests 50m --cpu-limits 75m
or
# specifying value as fraction
$kn service create --cpu-requests 0.5 --cpu-limits .1
Working on this based on above assumption as specified here
from client.
I would turn it around (as in --requests-cpu
) as imo one should also add --requests-memory
as well for the resource restrictions, so reflect the hierarchy like in resources spec itself.
BTW, any reason why memory was not included for this feature request ?
from client.
I agree with @rhuss for --requests-cpu
, --limits-cpu
, --requests-memory
and --limits-memory
.
Regarding the unit of resources, I think we should support both as described here.
from client.
OK makes sense @rhuss and @navidshaikh. Let me see if I can push something soon. Back at it this week so hopefully no more distractions. Best.
from client.
from client.
All, this is addressed in PR #81. I suggest we close unless something is missing. And if what is missing is "small change" to current implementation, just open a separate issue and I will address it.
from client.
Done by #81
from client.
Related Issues (20)
- New plugin "kn-plugin-search" for plugin discovery HOT 3
- Traffic split calculation should only use traffic-split revisions HOT 1
- Error: no Auth Provider found for name "azure" HOT 2
- Change to Sugar Controller will impact inject Broker functionality option of "Kn trigger create" HOT 3
- Issues with go-licenses HOT 4
- Add support for different volume types HOT 6
- Can't create private service using --no-cluster-local HOT 3
- Add `url` option for `kn service list --output` HOT 2
- Add support for providing sink spec in GVR format
- Add config option to specify `readOnly` volumes HOT 2
- Add `--scale-activation` flag to match new Serving option HOT 5
- Option to specify Node Selector HOT 2
- support uninstallation of local cluster using kn HOT 6
- Compile errors with Go 1.20 HOT 2
- kn does not show new trigger filters HOT 2
- Service export should handle securityContext field HOT 12
- Missing example of fully qualified GVR in`--sink` flag HOT 3
- Eventing TLS: support Eventing TLS in kn-plugin-event HOT 5
- `kn trigger update --help` information is incorrect HOT 2
- CLI: Add support for EventType v1beta2 HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client.