Compatibility with Turnip Features about knapsack HOT 5 CLOSED

@greggroth Hi, I've just did quick test and pattern works in case when .feature file has rspec tests.

I guess your .feature file has cucumber test inside so in that case you need to generate a separate report for cucumber tests and use cucumber adapter:
https://github.com/ArturT/knapsack#step-for-cucumber

from knapsack.

The specs are written using the gherkin syntax, but are ran using rspec, e.g. bin/rspec spec/features/logging_in.feature. Would that still require a separate report? I would think it would be included in the rspec report.

https://github.com/jnicklas/turnip

from knapsack.

Hmm, so it looks like rspec hooks were not fired and that's why report doesn't have .feature files.
https://github.com/ArturT/knapsack/blob/master/lib/knapsack/adapters/rspec_adapter.rb#L9

Maybe you are using a separate spec_helper.rb for .feature and you missed to bind there Knapsack::Adapters::RspecAdapter.

If I will find some time during weekend I can prepare test suite with turnip to debug the problem unless you will figure out it earlier.

from knapsack.

Thank you for the hint! I dug in and found it's an issue with Knapsack::Adapters::RspecAdapter.test_path's ability to parse the filename from example metadata. This is when running a turnip feature:

pry(#<RSpec::ExampleGroups::REDACTED::REDACTED>)> Knapsack::Adapters::RspecAdapter.test_path(::RSpec.current_example.metadata[:example_group])
=> "/Users/greggory/.gem/ruby/2.2.2/gems/turnip-1.2.4/lib/turnip/rspec.rb"

and with a normal spec file:

[1] pry(#<RSpec::ExampleGroups::REDACTED::REDACTED::REDACTED>)> Knapsack::Adapters::RspecAdapter.test_path(::RSpec.current_example.metadata[:example_group])
=> "./spec/models/user_spec.rb"

I'll dig in further and see if I can't put together a PR to improve this.

from knapsack.

Cool. You may want to take a look how I get the test file path in other adapters
https://github.com/ArturT/knapsack/tree/master/lib/knapsack/adapters

Please let me know if you will have something. In case you stuck I will help with that.

from knapsack.