Giter Club home page Giter Club logo

Comments (19)

kmikiy avatar kmikiy commented on May 29, 2024 8

ezgif-2-992c3106da

this is what i'm working on, there's still a long way to go. any help would be appreciated

from spotmenu.

 avatar commented on May 29, 2024 2

Something like that ? https://github.com/cbpowell/MarqueeLabel

from spotmenu.

NicholasBellucci avatar NicholasBellucci commented on May 29, 2024 2

ezgif-5-00f8856f1f9f

Let me know what you think and Ill look into making the PR. Threw it together pretty quickly. More needs to be done to make sure everything works but I could look into all of it.

from spotmenu.

JakobFelixJulius avatar JakobFelixJulius commented on May 29, 2024 2

Hi,
I created a pull request that lets the user define their own maximum width, that way the user can decide how much space should be used at max . Have a look here: #207
Cheers!
ScreenRecording2019-10-01at14115

from spotmenu.

cwaldau avatar cwaldau commented on May 29, 2024 1

Agreed! I couldn't figure out why sometimes I just wouldn't see SpotMenu in my menu bar. My theory is that when {{Artist}} - {{Song}} is too long it is just straight up not displayed. Fixed width with scrolling would also be my suggestion.

Screenshots below: Chrome has more menu items than Spotify does so a long title appears when on Spotify App but not on Chrome

screen shot 2017-04-24 at 8 04 56 pm

screen shot 2017-04-24 at 8 05 10 pm

from spotmenu.

NicholasBellucci avatar NicholasBellucci commented on May 29, 2024 1

I have created this class for my own project if you would like to take a look at implementing this view. https://gist.github.com/NicholasBellucci/b5e9d31c47f335c36aa043f5f39eedb2

demo

Disclaimer: This is an NSView that is added to the content view in the window of the NSStatusItem by accessing statusItem.value(forKey: "window") as? NSWindow.

from spotmenu.

NicholasBellucci avatar NicholasBellucci commented on May 29, 2024 1

So the feather icon that is next to the text is also part of my project. It is all added to statusItem.value(forKey: "window") as? NSWindow. One is an NSImageView while the other is the scrolling text view. I haven't looked into how you set SpotMenu up in the menubar but this is what mine looks like clicked. I didn't use interface builder however.

screen shot 2018-11-08 at 9 57 46 am

from spotmenu.

NicholasBellucci avatar NicholasBellucci commented on May 29, 2024 1

I had more time than I thought. Works for iTunes as well.

Playing
ezgif-5-5de3553fe639

Popover
ezgif-5-6083bac39e17

Pausing
ezgif-5-4703a3bcc3c9

from spotmenu.

kmikiy avatar kmikiy commented on May 29, 2024

Yes that's an OS feature, I've noticed it myself. I've gotten used to it. Scrolling would indeed be nice. I don't know how easy it would be to implement though, since I haven't found any open source libraries for scrolling labels for macOS I've only seen them for iOS.
I've been busy lately and haven't had time to deal with issues.

from spotmenu.

Raab70 avatar Raab70 commented on May 29, 2024

Scrolling might be difficult to implement but it would be nice if it only dropped the song title/artist when necessary and kept the spotify icon. That way the app is still accessible during songs with long titles.

from spotmenu.

 avatar commented on May 29, 2024

This could also be great for the widget in the Notification Center or the menu bar when hovering over the album art.

from spotmenu.

Raab70 avatar Raab70 commented on May 29, 2024

@fabi94music Yes that's almost exactly what I was thinking of.

from spotmenu.

frxncesdanielle avatar frxncesdanielle commented on May 29, 2024

@fabi94music how would i implement that to the app?

from spotmenu.

 avatar commented on May 29, 2024

Unfortunately I don't know.... :( I saw this recently and thought it could help but I'm not a programmer 🙈

from spotmenu.

frxncesdanielle avatar frxncesdanielle commented on May 29, 2024

@fabi94music awh.. it looks complicated aha i need help xD did you get it too?

from spotmenu.

kmikiy avatar kmikiy commented on May 29, 2024

Looks amazing 🙌🏻 Thank you for this. I was thinking I should add it to the PopOver.xib for starters. Adding it to statusItem.value(forKey: "window") as? NSWindow is probably going to take more time since I want it to work with the SpotMenu icon and now playing symbol (♬) seamlessly.

from spotmenu.

NicholasBellucci avatar NicholasBellucci commented on May 29, 2024

I will look into making a PR.

from spotmenu.

kmikiy avatar kmikiy commented on May 29, 2024

Looks good, but the music icon there is for indicating the music is played on iTunes 😬

Spotify:
screen shot 2018-11-08 at 4 33 48 pm
iTunes:
screen shot 2018-11-08 at 4 34 15 pm

This, currently is just a unicode character
screen shot 2018-11-08 at 4 35 28 pm

Also, if highlighting works correctly both in light and dark mode on macos (white text on blue background), then that would be amazing
screen shot 2018-11-08 at 4 32 04 pm

from spotmenu.

NicholasBellucci avatar NicholasBellucci commented on May 29, 2024

Yea I know. Logic has to be put in place to do what you were doing before, I just don't have too much time right now but I will later. Your comment helps though. And highlighting works full and it still scrolls when highlighted.

from spotmenu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.