Giter Club home page Giter Club logo

Comments (5)

remstone7 avatar remstone7 commented on July 24, 2024

It's not autogenerated, what changes are you looking to make?

from php-klaviyo.

loevgaard avatar loevgaard commented on July 24, 2024

Lots

  • Make a CI pipeline
  • Use Psalm
  • Up the requirement to PHP 7.4 including the code
  • Add more tests
  • Overall: make it more robust

What do you think? :)

from php-klaviyo.

remstone7 avatar remstone7 commented on July 24, 2024

all of that looks good we'd definitely appreciate it!

For php 7.4, would you be making this the minimum requirement or just expanding to support it?
For the ci, what would you be using?

from php-klaviyo.

loevgaard avatar loevgaard commented on July 24, 2024

Here is a first PR: #45

from php-klaviyo.

remstone7 avatar remstone7 commented on July 24, 2024

okay cool 👍 will review on the pr's, closing this issue!

from php-klaviyo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.