Giter Club home page Giter Club logo

Comments (7)

dresslerit avatar dresslerit commented on September 24, 2024

Should this button disappear (like visibility: hidden) or removed from the context (like display: none)?

from angular-material-icons.

cmacdonnacha avatar cmacdonnacha commented on September 24, 2024

I would say it should be "greyed out". See the same issue raised in the md-icon directive on angular material's project.

Something like this:

Call icon disabled:
image

Call icon enabled:
image

from angular-material-icons.

urmilparikh avatar urmilparikh commented on September 24, 2024

A PR will help....

from angular-material-icons.

patrickmichalina avatar patrickmichalina commented on September 24, 2024

👍 Yea this is pretty needed... Anyone working on it?

from angular-material-icons.

dresslerit avatar dresslerit commented on September 24, 2024

Hi, I found an solution but I'd like to discuss which one of these we should use in our general css:

/* Only if the element has the class .md-button and the option ng-disabled*
.md-button[disabled] ng-md-icon svg {
fill: rgba(0, 0, 0, 0.26);
}*/
/* Only if the Element ng-md-icon has ng-disabled*
ng-md-icon[disabled] svg {
fill: rgba(0, 0, 0, 0.26);
}
*/
/*Every element that has an svg inside and has the tag ng-disabled*/
*[disabled] svg {
fill: rgba(0, 0, 0, 0.26);
}

My favorite is the last one, because I don't want to type for every element a rule. But it may have some unexpected reactions of other styles in your code. (I didn't test that.)

from angular-material-icons.

urmilparikh avatar urmilparikh commented on September 24, 2024

I prefer the second method, will work only for ng-md-icon (or can make it work for md-icon as well).

from angular-material-icons.

cmacdonnacha avatar cmacdonnacha commented on September 24, 2024

Yea I'd go with the second option as well to avoid unexpected behavior with other styles.

from angular-material-icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.