Giter Club home page Giter Club logo

Comments (5)

nareshbhatia avatar nareshbhatia commented on June 17, 2024

Tried the latest commit. Still getting the same issue. Here's the line in my bower.json:

"angular-material-icons": "https://github.com/klarsys/angular-material-icons.git#576768adb4ef898f6739c2b3c26e85c617ec9977"

Am I doing something wrong? Do I have to do a local build or something like that?

from angular-material-icons.

urmilparikh avatar urmilparikh commented on June 17, 2024

@nareshbhatia, I need some way to reproduce the issue.

Can you checkout separately in a new folder, open index.html and see if the problem can be reproduced? Feel free to modify (and share) index.html / demo.js as required to reproduce issue.

It will be better if you can create a plunkr with the issue.

from angular-material-icons.

nareshbhatia avatar nareshbhatia commented on June 17, 2024

index.html/demo.js work perfectly fine in a fresh checkout to a local repository. Trying to investigate what's happening in my Angular Material app. Will post a plunkr with the issue.

Thanks.

from angular-material-icons.

nareshbhatia avatar nareshbhatia commented on June 17, 2024

I created pull request #35 to solve this issue. The problem is that the library and the demo do not use proper annotations and hence do not work in ng-strict-di mode. This would prevent the library to work correctly when compacted. Pull request #35 fixes this problem.

P.S. To reproduce the problem, simply add ng-strict-di to index.html

from angular-material-icons.

urmilparikh avatar urmilparikh commented on June 17, 2024

Thank you! I have pulled #35.

from angular-material-icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.