Giter Club home page Giter Club logo

Comments (4)

kkyr avatar kkyr commented on May 23, 2024 1

Hey, this is a great suggestion! Would make configs look a lot nicer :)

We could add a custom mapstructure DecodeHook and let it do the rest. Here's what I quickly cooked up:

type StringUnmarshaler interface {
	UnmarshalString(s string) error
}

func (l *ListenerType) UnmarshalString(s string) error {
	switch strings.ToLower(s) {
	case "unix":
		*l = ListenerUnix
	...
	}
	return nil
}

func StringToStringUnmarshalerHook() mapstructure.DecodeHookFunc {
	return func(f reflect.Type, t reflect.Type, data interface{}) (interface{}, error) {
		if f.Kind() != reflect.String {
			return data, nil
		}

		if reflect.PointerTo(t).Implements(reflect.TypeOf((*StringUnmarshaler)(nil)).Elem()) {
			val := reflect.New(t).Interface()

			if unmarshaler, ok := val.(StringUnmarshaler); ok {
				err := unmarshaler.UnmarshalString(data.(string))
				if err != nil {
					return nil, err
				}

				return reflect.ValueOf(val).Elem().Interface(), nil
			}
		}

		return data, nil
	}
}

// during map structure decoder init
dec, err := mapstructure.NewDecoder(&mapstructure.DecoderConfig{
	Result: &cfg,
	DecodeHook: mapstructure.ComposeDecodeHookFunc(
		StringToStringUnmarshalerHook(),
	),
})

WDYT?

from fig.

kkyr avatar kkyr commented on May 23, 2024 1

If you'd like to add this please open a PR and I'll gladly review.

from fig.

wneessen avatar wneessen commented on May 23, 2024

I tested it on my local fork of fig and it works like a charm. Thanks for the quick turnaround! Looking forward to use this.

from fig.

wneessen avatar wneessen commented on May 23, 2024

PR #29 created

from fig.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.