Thoughts on making KeyEvent accessible to ValidationContext? about rustyline HOT 5 CLOSED

An equally good solution, that is conceptually cleaner would be a way to register a custom handler for the Enter KeyEvent, which would then decide whether to forward on a Cmd::Newline or a Cmd::AcceptOrInsertLine / Cmd::AcceptLine. Is this possible somehow?

You mean like https://docs.rs/rustyline/latest/rustyline/trait.ConditionalEventHandler.html ?

from rustyline.

Similar projects don't seem to expose those details either:
https://docs.rs/reedline/latest/reedline/trait.Validator.html
https://python-prompt-toolkit.readthedocs.io/en/master/pages/asking_for_input.html?highlight=valid#input-validation
https://python-prompt-toolkit.readthedocs.io/en/master/pages/reference.html#prompt_toolkit.validation.Validator

from rustyline.

Similar projects don't seem to expose those details either:

That's a good point. Exposing editor details in the Validator isn't very conceptually pure if the role of a Validator is just to validate a line.

My problem is that Validator does double duty first determining if a given Enter event should be a newline or not, and then whether the line should be accepted / rejected.

An equally good solution, that is conceptually cleaner would be a way to register a custom handler for the Enter KeyEvent, which would then decide whether to forward on a Cmd::Newline or a Cmd::AcceptOrInsertLine / Cmd::AcceptLine. Is this possible somehow?

from rustyline.

You mean like https://docs.rs/rustyline/latest/rustyline/trait.ConditionalEventHandler.html ?

Exactly like that! I don't know how I missed that. 🤦 Thank you for the reply.

from rustyline.

I don't know how I missed that.

Mainly because rustyline documentation is not great like the one for python-prompt-toolkit.

from rustyline.