Comments (6)
This should be only happening in development mode, in production mode when using npm run build
the compiled css should be in an extra file because ExtractTextPlugin.extract
is configured.
from custom-react-scripts.
I’ve added a reduced testcase to https://github.com/jbach/custom-react-scripts-sass. Try running npm run build
, the css will not be extracted. Am I doing something wrong? Maybe I’m confused, but looking at config/customizers.js, I don’t see ExtractTextPlugin.extract
.
When I manually change the sass-loader in config/customizers.js
to
'SASS': {
toArray: 'loaders',
get: function () {
return {
test: /\.scss$/,
loader: ExtractTextPlugin.extract('style', "css!postcss!sass")
}
}
}
a separate CSS file is built.
from custom-react-scripts.
Just released 0.0.14 with a better fix for this. Now each customizer has a getDev and getProd functions. Should be ok now.
from custom-react-scripts.
Thank you for the fix, but can you confirm 0.0.14 is installable via npm? Installation via npm i custom-react-scripts
fails for me with Node 6.6.0 / npm 3.10.3. See my full npm-debug.log
npm ERR! Path must be a string. Received undefined
from custom-react-scripts.
Yes. I got the same error with Node v6.6.0. I also see other people [have this issue]with different npm packages (webpack/webpack#2463) but I have no idea why.
Installing the scripts with Node v.6.2.0 worked completely fine for me. Please try it and let me know.
from custom-react-scripts.
I’ll close this issue. The nonrelated install bug is described in #13
from custom-react-scripts.
Related Issues (20)
- how to use this package in an existing create-react-app ? HOT 5
- Is this for still active? HOT 7
- Async/Await is disabled? HOT 1
- I don't get it, sorry HOT 2
- SCSS does not respect NODE_PATH variable
- Responding to question on code HOT 1
- JEST scss transformation is missing
- Can't find build scripts
- Should `yarn build` work?
- How to tell when less is loaded?
- sass-resources-loader for global variables in SASS HOT 1
- Decorators fail when trying to build app in Travis CI
- Is there any way to get hot reloading of style changes to work with modules?
- Compatibility with vscode jest
- Less module is not working
- Upgrading isn't pulling the latest webpack dev config
- css modules className with --
- Remove radix eslint rule
- npm audit vulnerabilities
- Bug: babel rejects class properties
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from custom-react-scripts.