Change "name" to "tableName" in Table? about swift-kuery HOT 6 CLOSED

I am not sure I understand. Currently it's _name:

open class Table : Buildable {
    private var _name = ""

from swift-kuery.

Shmuel explained it to me, you want to change it in the subclasses of Table created by the users, right? I can do that (though it will cause a lot of changes in the tests, readmes, etc.).

from swift-kuery.

Hi @irar2 - it's up to you. Totally understand if it's a big change right now to implement. Not sure what is more clear. A subclass from Table that has a property called name or tableName. The "table" in tableName might be redundant. However, maybe name could be used for other properties the user creates.

from swift-kuery.

I kind of agree with the change, as name is probably a common column name. The trick here is how to avoid a conflict. tableName, while somewhat redundant, more likely avoids conflicts.

from swift-kuery.

OK, I will change name to tableName.

from swift-kuery.

ok, great, thanks.

from swift-kuery.