Comments (6)
Similarly:
Select(from: t).group(by: t.a, t.b).having(Parameter().in(Parameter(), Parameter()))
is generating:
SELECT * FROM tableSubquery GROUP BY tableSubquery.a, tableSubquery.b HAVING ?1 IN (?2, ?3)
which is returning no rows (instead of 6, as the test expects).
from swift-kuery.
SELECT * FROM tableSubquery GROUP BY tableSubquery.a, tableSubquery.b HAVING ?1 IN (?2, ?3)
is actually
SELECT * FROM tableSubquery GROUP BY tableSubquery.a, tableSubquery.b HAVING true IN (true, false)
and it looks like SQLite doesn't have boolean values. I'll add this to QueryBuilder.
from swift-kuery.
SELECT * FROM tableSubquery WHERE -7 IN (SELECT tableSubquery.b FROM tableSubquery WHERE tableSubquery.b = -1)
should return an empty result. Does SQLite always return nil instead of empty result? If so, we just need to change the tests.
I'm confused though, because as far as I can see the subquery should return no rows because t.b is never -1?
Yes, the subquery should return no rows, as well as the query, and the expected number of rows is 0. Posgres returns an empty result as expected.
from swift-kuery.
@ianpartridge Please change the tests in TestSubquery from:
s = Select(from: t).group(by: t.a, t.b).having(Parameter().in(Parameter(), Parameter()))
executeQueryWithParameters(query: s, connection: connection, parameters: true, true, false) {
...
s = Select(from: t).where(false.notIn(Parameter(), Parameter()))
executeQueryWithParameters(query: s, connection: connection, parameters: true, true) {
to
s = Select(from: t).group(by: t.a, t.b).having(Parameter().in(Parameter(), Parameter()))
executeQueryWithParameters(query: s, connection: connection, parameters: 1, 1, 0) {
...
s = Select(from: t).where(false.notIn(Parameter(), Parameter()))
executeQueryWithParameters(query: s, connection: connection, parameters: 1, 1) {
Here we pass booleans as parameters, and SQLite tests should use 1/0 instead of true/false.
from swift-kuery.
Ah, the SQLite driver doesn't support parameters at the moment. I haven't worked out whether that's a limitation of SQLite or the driver.
from swift-kuery.
Fixed
from swift-kuery.
Related Issues (20)
- Does the QueryParams support 'LIKE' filter?
- Swift build wont succeed HOT 2
- Swift Build failing HOT 2
- Add support for NOW() as a default value for timestamp columns HOT 1
- Add support for triggers / ON UPDATE
- Cache built queries
- Support INSERT .. ON CONFLICT
- ConnectionPool does not expose connection errors
- Make API for retrieving results asynchronous HOT 1
- Prepare and Release SwiftKuery 3.0 HOT 1
- Kuery 3.0 migration guide HOT 1
- MySQLThreadSafeConnection on version 3.0.0 HOT 2
- Replace enum for `QueryBuilder` substitutions
- ODBC Support HOT 2
- Getting computed value after insert/update/delete. HOT 6
- Add reset statement for prepared statements HOT 1
- Generic created_at and updated_at for Table HOT 1
- Using in NIO EventLoopFuture chains? HOT 1
- DISTINCT doesn't seem to work with JOIN
- Parameter is not working with sub-request
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-kuery.