Support database specific extensions about swift-kuery HOT 4 OPEN

I think this is a good approach. I'll carry on raising SQLite issues as I find them. We can close them in future.

from swift-kuery.

@irar2 as mentioned in #52 and this comment: link, I'll move extension discussions to this issue, so there is no multiple issues for the same feature.

In this commit i've implemented an initial implementation of Extensions.

However, we are not sure your injection points are sufficient

Does injection points mean Position that is used by Extendable protocol? It's designed to be query independent, so for every query the Position should be different.

and also the use of priorities in case of several extensions at the same position worries us.

Doest it mean that there should be no multiple extensions on the same position or that usage of priorities could be error prone if not used correctly?

from swift-kuery.

Hi @naithar,

Yes, by injection points I meant Position, and in my opinion Position is not flexible enough, it defines 5 points (for Select), and we prefer something more universal.

We think that priorities are error prone in this case.

from swift-kuery.

@irar2
String's Range could also be used for injection. The building of a query should probably be changed for this to work, since extension should receive parts of query which in SELECT's case is SELECT, FROM, WHERE and the others. It also should be aware of other extensions that is currently applied to the query to not cause any errors.
The extesion's build method could probably be like:

func injectExtension(into queryParts: [String]) -> [String]

or

func injectExtension(into query: String, to: Range) -> String

Priorities was designed to work with Position atm, so it won't be needed if we find a way to inject extension without it.

from swift-kuery.