Giter Club home page Giter Club logo

Comments (12)

KittyGiraudel avatar KittyGiraudel commented on May 27, 2024 2

I guess at some point I should probably catch up with Sass and try to understand what’s new. 😅

from sass-guidelines.

KittyGiraudel avatar KittyGiraudel commented on May 27, 2024 1

@robsonsobral Obviously! The more the merrier. My only expectation for the future of Sass Guidelines is that they are considered with the same amount of care they have been until now. :)

from sass-guidelines.

robsonsobral avatar robsonsobral commented on May 27, 2024

I came here to open an issue and... I already did!


I'm testing things. If I came to a conclusion, I come back and tell you!

from sass-guidelines.

KittyGiraudel avatar KittyGiraudel commented on May 27, 2024

Alright! 😊

from sass-guidelines.

robsonsobral avatar robsonsobral commented on May 27, 2024

Hey, big boss!

Remembering the current recommendation:

  • abstracts/:
    • _font-stacks.scss
    • _mixins.scss
    • ...
  • base/
  • components/
  • layout/
  • pages/
  • themes/
  • vendor/
  • index.scss

The abstracts need to be linked on every file of other folders, using @use '../abstracts/index' as my;, let's combine them on abstracts/_index.scss:

@use 'config';

@forward 'constants';
@forward 'font-stacks';
@forward 'functions' with (
  $my-base-url: config.$base-url,
  $my-breakpoints: config.$breakpoints,
  $my-font-weights: config.$font-weights,
  $my-gutter: config.$gutter,
  $my-palette: config.$palette,
);
@forward 'config';
@forward 'mixins';

The section 1 of the joining all file (which you insist on calling main.scss 😉 ) turns useless

@charset 'UTF-8';

// 1. Configuration and helpers
// @use 'abstracts/constants' as *;
// @use 'abstracts/stacks' as *;
// @use 'abstracts/functions' as *;
// @use 'abstracts/config' as *;
// @use 'abstracts/mixins' as *;

[...]

I'm considering to split the configurations in _color-palettes.scss, _ratios-and-scales.scss, _general.scss...

Too confusing?

from sass-guidelines.

KittyGiraudel avatar KittyGiraudel commented on May 27, 2024

Too confusing?

At this stage, yes. 😅 But I appreciate you taking the time to share your thoughts—thank you very much! I’ll try to make some time (and mind space) to come back to this issue soonish. :)

from sass-guidelines.

robsonsobral avatar robsonsobral commented on May 27, 2024

I already found more things to improve. Soon I'll show you!

from sass-guidelines.

Elrendio avatar Elrendio commented on May 27, 2024

Hello,

As sass official announced the deprecation of import and that use comes with a lot more features it would be amazing to update the guidelines 😊 (See Sass module system & official documentation of import and use)

Would you be open to a PR to propose new guidelines with use ?

Have a nice day,

Elrendio

from sass-guidelines.

KittyGiraudel avatar KittyGiraudel commented on May 27, 2024

Hello! 👋

I think we probably should, yes. However, it would be a good idea to draft version 1.4 of the Sass Guidelines, so we don’t sneak changes into the current version (1.3). By issuing a proper version 1.4 in English (including @use changes and other things we might find valuable to bundle), we can let translators bring their version to 1.4 as well in their own time.

Speaking of time, I have limited of it, and more importantly haven’t worked with Sass in 5+ years, so I’m not the best person to work on future versions of Sass Guidelines unfortunately. But maybe we could open an issue and list things that should be changed? Of the top of my head, I’d say @import to @use, and maybe the SCSS-lint version?

TL;DR: I’m all for updating literature around @import to suggest using @use, but I would love for it to be done as part of the next version of Sass Guidelines, and not just sneaked into the current English version. :)

from sass-guidelines.

Elrendio avatar Elrendio commented on May 27, 2024

Amazing 🤩 and completely agree!

I have a team specialized in front at my company and we're working on our guidelines. It could be the basis for Sass Guidelines (1.4). I'll create an issue by the end of the week 😊

PS: I'm very much impressed by your reaction time!

from sass-guidelines.

KittyGiraudel avatar KittyGiraudel commented on May 27, 2024

Nice, that sounds great. Let’s move that discussion to a dedicated issue then, and we can pick it up from there.

from sass-guidelines.

robsonsobral avatar robsonsobral commented on May 27, 2024

I would like to keep helping (in case @KittyGiraudel accepts, of course).

from sass-guidelines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.