Giter Club home page Giter Club logo

Comments (5)

cdguy avatar cdguy commented on June 22, 2024

Describe the bug As the title mentions.

To Reproduce Steps to reproduce the behavior:

  1. Open a HLG stream

Expected behavior

It should output HDR instead of DV, because that's the treatment tvOS gives to HLG content... (different from the DV profile that uses HLG metadata)

Screenshots https://github.com/kingslay/KSPlayer/assets/79731301/ec7cd1be-58ca-4743-98ae-e0f246487f20

Platform (please complete the following information):

  • Device: Apple TV 4K 2022
  • OS: tvOS 17.1

I can send a link to @kingslay of the kind of stream I mention, so he can see which parameters are needed to identify HLG.

[email protected]

also use this for the mail subjet: HLG output as Dolby Vision instead of HDR #615

from ksplayer.

kingslay avatar kingslay commented on June 22, 2024

@edge261 你可以发一个一分钟的视频片段到github。这样我就可以测试了。目前视频是输出为dolbyVision,你是想要视频能够输出为HDR10吗?

from ksplayer.

kingslay avatar kingslay commented on June 22, 2024

你可以简单的改下代码把var dynamicRange: DynamicRange { 这个函数返回值改成是.hdr10 进行测试,看下效果怎么样。看是否符合你的预期。

from ksplayer.

edge261 avatar edge261 commented on June 22, 2024

你可以发一个一分钟的视频片段到github。这样我就可以测试了。目前视频是输出为dolbyVision,你是想要视频能够输出为HDR10吗?

@kingslay I sent a link to your email, please check. I don't know how to rip a clip so I prefer to send it...

And yes, it should output HDR10, since that's tvOS implementation.

https://developer.apple.com/forums/thread/666586

from ksplayer.

edge261 avatar edge261 commented on June 22, 2024

你可以简单的改下代码把var dynamicRange: DynamicRange { 这个函数返回值改成是.hdr10 进行测试,看下效果怎么样。看是否符合你的预期。

Well, I believe it was done on one of the apps that uses KSplayer because I reported it directly and it fixed it.

However, it would be good to have that fixed for all the apps that uses this library so everyone gets the correct implementation instead of a per-app basis.

from ksplayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.