KSPlayerLayer set display criteria although `displayCriteriaFormatDescriptionEnabled` is `false` about ksplayer HOT 7 CLOSED

AVDisplayCriteria 有两个初始化方法，一个是tvOS17 才有的 AVDisplayCriteria(refreshRate: refreshRate, formatDescription: formatDescription)。 displayCriteriaFormatDescriptionEnabled这个开关就是用来控制这个初始化方法的。 另一个是AVDisplayCriteria(refreshRate: refreshRate, videoDynamicRange: videoDynamicRange)。 你应该是有重载了preferredDisplayCriteria，然后走了AVDisplayCriteria(refreshRate: refreshRate, videoDynamicRange: videoDynamicRange) 这个方法吧。

from ksplayer.

I understand that, and I already have the logic to do so. The problem is infrastructural. I don't want the player to automatically set the display criteria. There should be an option to decide this.

Also, when setting the criteria on live streams with KSMEPlayer, the stream goes bad.

As part of this problem there's also the fact that if the user wants to disable and then reenable the matching content while watching a stream, I don't have access to the MetalPlayView formatDescription, because is private. Therefore I can't set again that format description. Only the track's one.

These are all design problems that can be easily solved.

from ksplayer.

So imagine I have my custom player, which use your engine under the hood.

I want to be able to enable and disable content matching whenever I want, with my logic.
Therefore I need:

1. Get informed when MetalView generated the format description, which is the only one working well enough for lives;
2. Have access to MetalView generated format description;
3. Be able to disable the KS inner logic to set display criteria.

One big step for this project is to well separate the concept of "Player" and "Controller". I use the Player, but I have my Controller. So things can't be mixed up.

To help, take in consideration "AVPlayer" and "AVPlayerController".

from ksplayer.

The commit you posted for this has broken 4K 50fps playback. it's losing loads of frames and is now jerky/stuttering playback - totally unwatchable.

from ksplayer.

The commit you posted for this has broken 4K 50fps playback. it's losing loads of frames and is now jerky/stuttering playback - totally unwatchable.

displayCriteriaFormatDescriptionEnabled 这个值是为false吗？

from ksplayer.

The commit you posted for this has broken 4K 50fps playback. it's losing loads of frames and is now jerky/stuttering playback - totally unwatchable.

displayCriteriaFormatDescriptionEnabled 这个值是为false吗？

It was set to true. tried with false and now it's ok.

from ksplayer.

@kingslay you missed this

    `UIApplication.shared.windows.first?.avDisplayManager.preferredDisplayCriteria = nil`

It should also be covered by the flag.

from ksplayer.