Giter Club home page Giter Club logo

Comments (5)

johannesfritsch avatar johannesfritsch commented on May 27, 2024

Just saw that there is a pending PR for this. Please consider accepting it. It seems reasonable to me :-)

from aor-loopback.

kimkha avatar kimkha commented on May 27, 2024

I'm still thinking about that PR. Is it better? I'm not sure if we change to PATCH it will work for other cases?

from aor-loopback.

kimkha avatar kimkha commented on May 27, 2024

I also merge that PR... :)

from aor-loopback.

kodepareek avatar kodepareek commented on May 27, 2024

Guys this is a pretty big change. I will have to go through my entire API and make appropriate changes now. Did we follow Semver for this?

While I agree that Patch is a better option that put any day. This kind of change should have been more carefully done.

from aor-loopback.

kimkha avatar kimkha commented on May 27, 2024

I really think 'PATCH' is better than 'PUT'. That's why I accept this PR.

The difference between them is: 'PUT' can "delete" some fields. But with 'admin-on-rest', it's useless, because 'admin-on-rest' don't support "deleting field", only set to null (or empty '').

Thank you anyway.

from aor-loopback.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.