Comments (10)
"tuned seems to not exist on debian"
It doesn't. In the start-up Ginger will try to run 'tuned-adm' and, if not successful, the whole power management feature won't show up in the UI. Most of Ginger features behave the same way.
"there are other errors for sensors that is not used on P8 for info retrieving. Onboard sensors info retrieving is not done with a classical tool"
I'll check it out
"ginger makes use of IBM Serviceable Event Provider on PowerKVM (package serviceable.event.provider) but it's not available on debian as well and seems also closed source"
Good point
"vfio pci is not available on 3.16.0 used on debian ; this seems to be not available on debian's 3.16, but on later kernel (3.19 I saw) and on PowerKVM custom 3.10"
Another good point. I'll bring these points to the community and then we'll try to figure it out how to act.
"Are these messages minor? (not breaking in some way)"
Some of them are just the backend trying to resolve if a specific feature is available or not. Kimchi does that as well. I agree that it's not the cleanest way to do it.
from ginger.
One thing to consider is that tuned, ibm-sep and others aren't 'must have' for Ginger. You might consider them as "optional" dependencies. The plug-in is able to handle the situations where these optional packages are present or not due to a new API that was developed last year.
If you look at the file https://github.com/kimchi-project/ginger/blob/master/contrib/DEBIAN/control.in you'll see that I've declared only 'kimchi' and 'python-libuser' as installation dependencies for Ginger.
About the vfio module: I've checked it out the 'vfio-pci' message and it doesn't come from Ginger. It is a Kimchi message. It is the Kimchi way to check if the host's kernel has vfio support. This dependency should be treated (or not, I think it's an optional dependency from Kimchi) in Kimchi packaging/installation.
from ginger.
Thank you Daniel for checking these.
Yes I took the deps from what you did and added those : lm-sensors, hddtemp, powerpc-ibm-utils [powerpc ppc64 ppc64el]
For vfio-pci, I don't see a way for kimchi packaging to pull it. The module will be part of the kernel and either it will be compiled or not and in this case, there's nothing to be done. So if
it doesn't harm on kimchi side, that's ok like that.
Btw, here the ITP on debian bugzilla for details : http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775747
from ginger.
Bump
I understand that you're asking to remove/hide the dependencies messages in logs. Is that correct?
from ginger.
If something could be done, I'd see an intermediate solution like a debug level that could hide messages fully or partially with a default that won't scares and be informative while not being totally quiet :
[info] Testing : tuned ...
[debug] Failed to run command: tuned-adm active. [Errno 2] No such file or directory
[info] Unavailable : disabling use of tuned
[info] Testing : needed-feature-or-binary
[debug] Failed to run command: needed-feature-or-binary
[error] Ginger requires needed-feature-or-binary
With a verbosity order of debug [most verbose], info , error [less verbose].
If I set the default to 'info', I'll see only [info] and [error] message which is informative
With 'error' level? it'll be mostly quiet, display only the last message in case of real problem.
And 'debug' level will print everything as above.
That said, it's just a nice to have to my opinion ; others may think differently :)
from ginger.
It is a good idea, but we need to discuss it with Kimchi as well. I can
fix the Ginger side but I don't think the results will be as expected if
Kimchi messages continues to appear in the log as is.
I think you can open this issue in Kimchi github, referencing this
entry as the origin. What do you say?
On 02/25/2015 12:11 PM, frediz wrote:
If something could be done, I'd see an intermediate solution like a
debug level that could hide messages fully or partially with a default
that won't scares and be informative while not being totally quiet :|[info] Testing : tuned ...
[debug] Failed to run command: tuned-adm active. [Errno 2] No such file or directory
[info] Unavailable : disabling use of tuned
[info] Testing : needed-feature-or-binary
[debug] Failed to run command: needed-feature-or-binary
[error] Ginger requires needed-feature-or-binary
|With a verbosity order of debug [most verbose], info , error [less
verbose].
If I set the default to 'info', I'll see only [info] and [error]
message which is informative
With 'error' level? it'll be mostly quiet, display only the last
message in case of real problem.
And 'debug' level will print everything as above.That said, it's just a nice to have to my opinion ; others may think
differently :)—
Reply to this email directly or view it on GitHub
#8 (comment).
from ginger.
@frediz is this bug applicable?
from ginger.
Based in the discussion, I will change the issue description to "Add log level support to Ginger"
Please, feel free to change if I misunderstood on what was proposed here.
from ginger.
Now that we have Wok, it's possible to adjust the log level for Kimchi and Ginger at same time by changing DEFAULT_LOG_LEVEL in wok/config.py.in to "info" or "warning" or even "error" instead of the current "debug".
from ginger.
Fixed on Wok acf14434f122dd635340df0233cfef3f5c14a508 1c48a30d4ce61708348e93230174c69430986752
from ginger.
Related Issues (20)
- HVM:Swap Devices: 'Adding' a /dev/dasd based swap device yields an error.
- HVM:Storage Devices panel 'Filter' sits at the 'Loading...' spinner
- Delete partition fails on multipath luns and iscsi devices HOT 1
- Create physical volume fails on dasd/iscsi/fclun partitions HOT 1
- FVT]: Network: Minor UI Observations in "Network Configuration" and "Add Adapter" panel
- Double popup issue after loading list of unloaded modules
- Frozen screen after loading module
- Cannot delete user when she doesn't have home directory
- Refresh button does not work for Administration->Users
- make check fails without sudo in opensuse 42.2
- check_i18n.py and tests are not included in dist tarball
- make check fails inside tarball F25
- Network Tab got problems with datatables on F25 HOT 3
- Translation not complete on F25
- Enable SMT configuration for ppc64 hosts
- Error while attaching interface to a ovs bridge and deleting the bridge
- make's error for SuSE and Fedora, and their patch
- [feature request] export function
- Version Update Needed
- plugin doesn't load
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ginger.