Comments (5)
Actually 'make check-local' just verifies code integrity (pep8 and stuff) if you're considering Kimchi as a base. It is 'make check' that should run the code integrity check of check-local and the unit tests too.
from ginger.
Daniel,
I just cross checked, make check and make check-local both execute the test cases in case of wok framework.and kimchi plugin.
bash-4.3# pwd
/home/Abhiram18/kimchi/tests
content of Makefile.am has
check-local:
./run_tests.sh
On the same lines i was assuming i had to update the Makefile.am in ginger tests(ginger/tests/makefile.am) with below content,
check-local:
./run_tests.sh
Let me know if this is fine?
from ginger.
We're talking about different files. I was talking about make check-local at project root. For example, in Kimchi:
[danielhb@arthas kimchi]$ make check-local
contrib/check_i18n.py ./i18n.py
Checking for invalid i18n string...
Checking for invalid i18n string successfully
find . -path './.git' -prune -type f -o \
-name '*.py' -o -name '*.py.in' | xargs /usr/bin/pyflakes | \
while read LINE; do echo "$LINE"; false; done
/usr/bin/pep8 --version
1.6.2
/usr/bin/pep8 --filename '*.py,*.py.in' --exclude="*config.py,*i18n.py,*tests/test_config.py" .
[danielhb@arthas kimchi]$
Note that the tests aren't run after firing "make check-local" at Kimchi root. Same thing with wok.
However, I just verified that the change you've proposed (without the /data/screenshots line because we do not have that in Ginger) in tests/Makefile.am allows 'make check' from Ginger root to run the unit tests as well. So go ahead and make the change. Pay attention to the TAB indentation at Makefile.am, otherwise it will fail.
And, if I may suggest, you can enhance the 'check-local' target at Ginger root to do the same steps as Kimchi/Wok. As far as I just checked here it is simply a matter of adding the line
contrib/check_i18n.py $(I18N_FILES)
At the start of the check-local target at Makefile.am of Ginger root (disclaimer: I've not tested it, just speculating). You can add this change in this same patch/issue if you like.
Daniel
from ginger.
@abhiramkulkarni let me know if you're still interested in doing this enhancement
from ginger.
Will be working on this issue in coming weeks
from ginger.
Related Issues (20)
- HVM:Swap Devices: 'Adding' a /dev/dasd based swap device yields an error.
- HVM:Storage Devices panel 'Filter' sits at the 'Loading...' spinner
- Delete partition fails on multipath luns and iscsi devices HOT 1
- Create physical volume fails on dasd/iscsi/fclun partitions HOT 1
- FVT]: Network: Minor UI Observations in "Network Configuration" and "Add Adapter" panel
- Double popup issue after loading list of unloaded modules
- Frozen screen after loading module
- Cannot delete user when she doesn't have home directory
- Refresh button does not work for Administration->Users
- make check fails without sudo in opensuse 42.2
- check_i18n.py and tests are not included in dist tarball
- make check fails inside tarball F25
- Network Tab got problems with datatables on F25 HOT 3
- Translation not complete on F25
- Enable SMT configuration for ppc64 hosts
- Error while attaching interface to a ovs bridge and deleting the bridge
- make's error for SuSE and Fedora, and their patch
- [feature request] export function
- Version Update Needed
- plugin doesn't load
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ginger.