Giter Club home page Giter Club logo

Comments (5)

kimbtech avatar kimbtech commented on July 20, 2024 1

Hi,
as tackin already stated, the links to the logos are send to the radio and the radio requests them itself.
The radio supports png file, but not https, which might be the reason for one logo working and one not:

  • https://www.antenne.de/logos/station-antenne-bayern/apple-touch-icon.png works, but http://www.antenne.de/logos/station-antenne-bayern/apple-touch-icon.png without s redirects to the https version.
  • https://cdn-profiles.tunein.com/s25260/images/logod is also available without s, i.e., http://cdn-profiles.tunein.com/s25260/images/logod

You may notice, that your links to the logos are using https both times, but Radio-API tries to send urls without https to the radio. Thus, the radio gets http://www.antenne.de/… and https://cdn-profiles.tunein.com/… whereas only one link works.

As solution, Radio-API would need to download the logos and provide them to the radio without requiring https. (Similar to the proxy for streams). However, this is currently not implemented, but might be an upcoming feature.

In the meantime, one might manually add the logos to Radio-API:

  1. Add the line - ./media/:/php-code/media/ to the docker-compose volumes section. (Not required in non-Docker mode.)
  2. Download the missing logos and move them to ./media/ as, e.g., antenne.png
  3. Set http://<my-radio-api-server>/media/antenne.png as station logo.

from radio-api.

Demel75 avatar Demel75 commented on July 20, 2024 1

information submitted later:
This station works with png.
image

So png support should be there.

@kimbtech yes, the http/https stuff seems the problem. Thanks for analyse and maybe the enhancement. Good job!

from radio-api.

Demel75 avatar Demel75 commented on July 20, 2024 1

:-) Great job. Works like a charm. Thanx

from radio-api.

tackin avatar tackin commented on July 20, 2024

Your radio only gets the information where to pull the logo from.
The above logo-links provided to the radio are working.
If one external link is working (.jpg) and others are not (.png) my best guess is, your radio might simply not support ".png"-files.

from radio-api.

kimbtech avatar kimbtech commented on July 20, 2024

Hi, I just published an update providing an image cache solving the problem of SSL served logos.

from radio-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.