Comments (4)
Hi @binarykitchen, thanks for your feedback!
I'm a bit confused, this seems to be an angular.js issue, contains
method is not provided by jqlite.
Could you provide a playground to test this behavior?
from jqlite.
i am afraid, i cannot reduce this to a small test case. things in the angular code seem to be too bloated.
but i think we should add a check whether window.Node
is defined. if not, then use that function.
from jqlite.
Hi again @binarykitchen , I've added $.contains method to jqLite, maybe this can be helpful for you.
According to angular issue #10259, this behavior can be escaped with following snippet:
if (typeof SVGElement.prototype.contains == 'undefined') {
SVGElement.prototype.contains = HTMLDivElement.prototype.contains;
}
In general, I prefer to avoid add hacks and polyfills to jqLite in order to avoid mistake libraries that detects browser support (like modernizr)
from jqlite.
@jgermade do i need to replace the buggy code
var jqLiteContains = window.Node.prototype.contains || /** @this */ function(arg) {
// eslint-disable-next-line no-bitwise
return !!(this.compareDocumentPosition(arg) & 16);
};
with if (typeof SVGElement.prototype.contains == 'undefined') {
SVGElement.prototype.contains = HTMLDivElement.prototype.contains;
}
or do it need to place it somewhere
from jqlite.
Related Issues (20)
- add .hide() and .show() function HOT 6
- add the .add() function HOT 3
- adding CSS functionality HOT 3
- add .prev() , .prevAll() , .siblings() functions HOT 4
- binding and unbinding keypress HOT 9
- one() on multiple elements only unbind the activated element HOT 6
- How to use with browserify HOT 6
- Data API should be stored object HOT 3
- Style change event detection HOT 1
- filterDuplicated Error HOT 1
- Re-consider ListDOM'a array-like object implementation HOT 2
- How to avoid collision with Jquery HOT 22
- Adding WrapAll() and unWrap() function HOT 2
- Unbind all listeners of the same event type HOT 10
- Supporting extend method HOT 6
- considering add dataset, classList polyfills HOT 2
- "hasClass" logic in toggleClass function HOT 3
- classListMethods never declared HOT 1
- Minified jqlite does not work in browser HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jqlite.