Giter Club home page Giter Club logo

Comments (3)

sbrossie avatar sbrossie commented on May 24, 2024

We fixed half of the issue by:
1 - removing the calls that were sensitive to latency-- entitlement IMM events-- but not using notificationQ.
2 - Create a dispatcher to fetch ready notifications across all queues and also prefetching a few notifications at once.

As a result we don't have to be aggressive in the polling and point 1 becomes less relevant.

Ordering still need to be addressed at some point.

from killbill.

sbrossie avatar sbrossie commented on May 24, 2024

We revisited that task-- for now we will not do the multiple locking strategy described above). Instead:

  1. Extract Bus+ NotificationQ into new killbill-common repo
  2. Fix Bus intensive queries by
    2.1 Dispatch from the post itself-- from context of a different thread-- instaed of polling for event on disk
    2.2 Still insert row on disk to cover failure scenarii and also for debugging purpose
    2.3 Move Processed row into different table to keep main table with a short number of rows
    2.4 Add a background polling mechanism for rows that were not processed
  3. Revisit abstractions for:
    3.1 Dealing with internal/external bus
    3.2 Allow to plug KB lifecycle and initialize/start bus at the right time
  4. Query optimization (remove NULL processing_owner to allow for better indexing)
  5. Design plugin service for notificationQ

from killbill.

sbrossie avatar sbrossie commented on May 24, 2024

The code has been extracted under killbill-commons:

  • Bus and notificationQ code has been abstracted (we can create multiple bus'es and notificationsQ)
  • The performance issue with the bus has been addressed by keeping in in memory queue and doing select using record_id
  • The growing tables has been addressed by creating history tables.

This is all we will do for now. Closing the bug

from killbill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.