Giter Club home page Giter Club logo

Comments (2)

Kigstn avatar Kigstn commented on June 12, 2024 1

Hmm, sadly I haven't played around with that before. I'll take a look next week - will report back my findings :)

from bungio.

Kigstn avatar Kigstn commented on June 12, 2024 1

@kennedy
From looking at the fastapi code, it looks like you are using it wrong / OAuth2AuthorizationCodeBearer is not working correctly / bungie is simply not following the oauth standart well enough. For example, bungie does not allow passing a redirect url as a query param.

Sadly it's kind of annoying to figure out what exactly fastapi does in the background since OAuth2AuthorizationCodeBearer is not documented anywhere (yet)...

As a workaround, if you change

authentication = OAuth2AuthorizationCodeBearer(
    authorizationUrl=client.get_auth_url(state=secrets.token_urlsafe(20)),
    tokenUrl="https://www.bungie.net/platform/app/oauth/token/",
)

to

authentication = OAuth2AuthorizationCodeBearer(
    authorizationUrl=client.get_auth_url(state=secrets.token_urlsafe(20)),
    tokenUrl="https://www.bungie.net/platform/app/oauth/token/",
    auto_error=False,
)

fastapi won't error out and you can complete the auth flow as you did - since it mainly relies on bungio not fastapi :)

from bungio.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.