Comments (10)
AndrianBdn
commented on June 28, 2024
1
@bzon @phinexdaz that was interlaced PNG file; I've updated the code to support it
just returning nil is wrong — colors are not converted
from ipapk.
kiethen
commented on June 28, 2024
I can't build this project without the Mac, can you give me the IPA file.
2018-05-24 11:03 GMT+08:00 Bryan Sazon <[email protected]>:
… Problem:
NewAppParser fails when reading the IPA file built from
https://github.com/browserstack/xcuitest-sample-browserstack.
Work around:
I had to modify AndrianBdn/iospng/iospng.go
<https://github.com/AndrianBdn/iospng/blob/master/iospng.go> line 104
from return ErrImageData to return nil to solve the issue.
Does this mean that the browser stack sample app has bad png icon files?
How should we handle this?
I've used this library multiple times on different IPA but the sample from
browser stack fails to be read.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEt0yhOCBvMrJlbzyuAXau2wNsQVKWMtks5t1iMFgaJpZM4ULfZw>
.
from ipapk.
bzon
commented on June 28, 2024
@phinexdaz I've attached it in the issue description.
from ipapk.
kiethen
commented on June 28, 2024
Sorry, just noticed that.
does this IPA have an icon in the simulator
from ipapk.
bzon
commented on June 28, 2024
@phinexdaz it does have an Icon. See the attached app icon. This is the output of running NewAppParser with my fix mentioned in the workaround.
from ipapk.
bzon
commented on June 28, 2024
@phinexdaz this is how I fixed it bzon/iospng@8946b47
from ipapk.
kiethen
commented on June 28, 2024
yeah, it seems to be working, or remove the function rawImageFix.
from ipapk.
bzon
commented on June 28, 2024
@phinexdaz Can we consider this as the fix? Should we fork that project? I did and is already using my own iospng fork in my ipapk fork.
from ipapk.
kiethen
commented on June 28, 2024
https://gist.github.com/urielka/3609051#file-ipin-py-L84
rawImageFix can return nil if len(raw) != w*h*4 + h
from ipapk.
bzon
commented on June 28, 2024
Fixed in AndrianBdn/iospng@eb5ebcd
from ipapk.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ipapk.