Giter Club home page Giter Club logo

Comments (12)

mswiderski avatar mswiderski commented on July 21, 2024

have you modified the tests in any way? and what is the time zone you're in as that might be specific to timezone?

from jbpm-wb.

salaboy avatar salaboy commented on July 21, 2024

Do you have any local changes?
It is working locally, so it might be related with your local environment. There is no way to fix if we don't find the cause..
@maciej is it failing in your local env?

from jbpm-wb.

mswiderski avatar mswiderski commented on July 21, 2024

@salaboy nope, works as expected, I even tried with the same date that is mentioned in the stack trace but still no luck to reproduce the problem.

from jbpm-wb.

psiroky avatar psiroky commented on July 21, 2024

If I remember correctly this issue is related to particular timezone(s) (as Maciej pointed out). I think @porcelli seen same (similar) issue some time ago. I will look into it (as I wrote the tests originally) once I have a minute or two.

from jbpm-wb.

rezangit avatar rezangit commented on July 21, 2024

No changes at all, I just get a fresh copy from Git every time to test and then remove all folders
about timezone

date +%Z
IRST
date +%z
+0330

I can build master branch with this command without any error
mvn clean install -DskipTests

from jbpm-wb.

salaboy avatar salaboy commented on July 21, 2024

@psiroky thanks I will appreciate if you take a look on those tests

from jbpm-wb.

psiroky avatar psiroky commented on July 21, 2024

The issue can be reproduced by adding following line at the start of method testGetTasksForLongPeriod().

DateTimeZone.setDefault(DateTimeZone.forTimeZone(TimeZone.getTimeZone("Brazil/East")));

It is related to the daylight savings time which is handled differently in different countries. I will look at how to fix the tests/implementation.

from jbpm-wb.

rezangit avatar rezangit commented on July 21, 2024

I just changed my timezone to Vancouver/Canada and problem solved.

sudo dpkg-reconfigure tzdata

Thanks for help.

from jbpm-wb.

mswiderski avatar mswiderski commented on July 21, 2024

alright the fix is to replace LocalDate.toDateMidnight() with LocalDate.toDateTimeAtStartOfDay() inside TaskServiceEntryPointImpl.transformLocalDatesToDays and that solves the problem. Any thoughts? If no objections I'll create jira and push it to master.

from jbpm-wb.

psiroky avatar psiroky commented on July 21, 2024

@mswiderski thanks for looking into this! Yes, the LocalDate.toDateTimeAtStartOfDay() is the right way to handle it. I am sorry for the inconvenience I caused, that method should have been used from the beginning.

from jbpm-wb.

mswiderski avatar mswiderski commented on July 21, 2024

@psiroky no worries, thanks for confirming the fix, I'll push that in.

from jbpm-wb.

mswiderski avatar mswiderski commented on July 21, 2024

fixed as part of this jira: https://issues.jboss.org/browse/JBPM-4226

from jbpm-wb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.