Get rid of SPV_VALIDATE_*_BITs about spirv-tools HOT 6 CLOSED

I was planning on using spvBinaryParse like this and calling the passes individually. This should be easily generalizable in a fixture.

from spirv-tools.

I tried a couple of approaches to get around this. One approach was to pass the *Pass function pointers to the ValidateInstructions function. Another was to ignore the errors based on the type of flags passed into the ValidateState_t::diag function. I don't think either of these approaches solved the problem we have been experiencing.

The only solution would be to parse the entire binary for each of the passes. This will allow us to test for each type of pass independently. This will obviously be slower but might solve this issue.

Thoughts?

from spirv-tools.

@umar456 I don't like the idea of needless repeated parsing. Is it not possible to fix the test assemblies not to trigger unrelated validations? A lot of the time it's something trivial, like missing OpMemoryModel.

from spirv-tools.

@umar456 is it OK if we assign this to someone on our team?

from spirv-tools.

sure

from spirv-tools.

In master as b6ccd0d.

from spirv-tools.