Comments (2)
Look like I fixed the surface issue with #5561. However, I do not understand how we were getting the earlier result in the first place. I did not think that the OpSMod would have been folded, so it seems like there might be another bug that is now hidden. I'll leave this open while I try to determine what was happening before my change.
from spirv-tools.
The code that originally folded the OpSMod, would do an OSRem
and then try to "fix" the value to account for the difference in definition:
SPIRV-Tools/source/opt/fold.cpp
Lines 109 to 111 in 784b064
The problem is that the third line overflows in this case, and give an incorrect value. Since we have a new implementation for OpSMod folding, which does not have this problem. I will simply delete that code.
from spirv-tools.
Related Issues (20)
- spirv-val reports OpName and OpLine as not same section HOT 2
- About project version scheme HOT 2
- Fuzzer: CMake configuration failed for protobuf - fuzzer unbuildable HOT 1
- Issue with EliminateDeadOutputStores when reading from out variable HOT 1
- Need AppleSilicon or universal apps for all the spriv tools on macOS HOT 5
- Add CLI option to set CreateAggressiveDCEPass(true) HOT 7
- New spriv-cross not transpiling to "void" vertex functions for SSBO usage HOT 2
- spriv-tools build of spirv-cross is really old HOT 3
- Constant initialized global variable rewrites produce invalid IR HOT 1
- OpUConvert for specialization constant should not generate spirv-opt error. HOT 2
- update validator tests for SPIRV-Headers change removing Kernel capability from Image channel order query result enums HOT 1
- String endianness is incorrect: big-endian strings cannot be read on little-endian machines
- spirv-opt problems HOT 3
- how best to add validation for Kernel SPIR-V HOT 1
- Building SPIRV-tools Error HOT 1
- Vulnerability: UNKNOWN READ in spvtools::val::ValidateAccessChain affecting HOT 2
- Fails to compile with GCC 13.2 (SPV_OPERAND_TYPE_OPTIONAL_RAW_ACCESS_CHAIN_OPERANDS not declated) HOT 1
- [spirv-opt] Inlining pass generates OpVariable of PhysicalStorageBuffer pointer type without AliasedPointer decoration. HOT 2
- spirv-val: VUID-FragCoord-FragCoord-04212 interaction with PerVertexKHR HOT 7
- Compile-related issue: SPIRV-Headers not found HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spirv-tools.