Cannot compile as C library, has to be C++ about spirv-tools HOT 8 CLOSED

The problem is upstream. This file comes from the SPIR-V repo, and we've been reluctant to change it locally.

Keeping the issue open for now, until it's resolved.

See also #138.

from spirv-tools.

Oh, didn't see that. :)

from spirv-tools.

Sorry about the problem persisting. I've fixed our code when I closed #138, but it's still impossible to compile in C. 😞

We're hesitant to diverge OpenCL.std.h because it complicates upgrading from upstream.

@antiagainst: might #170 resolve this, do you think?

from spirv-tools.

It's really not a big thing for me. I simply patched my local repo version and will keep it at that.
It's not like the OpenCL.std.h is going to change frequently.
And if it is abount to change again, then maybe you guys could persuade Khronos to add a tiny little ifdef guard around it for the future? :)

from spirv-tools.

Yes, we're working on having it fixed at the source. And now that I've reviewed #170, I can confirm that it will remove all public-API dependence on upstream headers. 👍

from spirv-tools.

@dekimir: Yeah. :) Sorry for the late reply. With #170, users of libspirv.h are free of upstream SPIR-V headers.

from spirv-tools.

Hi @httpdigest, #170 is merged so it should be able to compile as C library now. Thanks!

from spirv-tools.

Hi @antiagainst, yes clients compile now fine using C-only. Thanks!

from spirv-tools.