spvTextToBinary cannot handle CR+LF unless fread is used by client about spirv-tools HOT 5 CLOSED

We could broaden our definition of whitespace, assuming there are no unexpected side-effects.

from spirv-tools.

Thanks for the bug report. Yes, we should handle this. The only tricky part is recognizing that \r\n advances only a single line forward, for line counting.

It's also nice to see someone using the fact that SPIRV-Tools is a C API. :-)

from spirv-tools.

Thanks for noting and for wanting to fix this! Yes, SPIRV-Tools as a library is a very useful tool to assemble spir-v at runtime!
The C fread() function btw. is horrible. :)
With a libc on linux it does not even convert CR+LF to LF but just treats "r" mode the same as "rb" mode. So it would currently not be possible to read assembly on Linux that was written on Windows (i.e. with CR+LF line endines). Not even with the "as" tool using fread() "r".
I'd definitely be in favor of handling different line breaks in the library itself.

from spirv-tools.

@httpdigest should be fixed now, please give it a whirl...

from spirv-tools.

Confirmed. Works fine! :) Thanks.

from spirv-tools.