update_build_version script syntax and str object issues about spirv-tools HOT 5 CLOSED

@bschindler: The script is using python2 syntax right now. The print error results from syntax difference between python2 and python3.

If you have python2 installed, you may want to change the first line of utils/update_build_version.py to #!/usr/bin/env python2 or symlink your system Python to python2.

Sorry for the inconvenience, we'll fix the issue.

from spirv-tools.

That does explain it. Using python2 did work here. Thanks for the response

from spirv-tools.

Let's keep this open and make the script work for both Python 2 and Python 3.

from spirv-tools.

Note that changing the first line of utils/update_build_version.py to python2 doesn't work when cmake finds python3 and uses it to call the script:
https://github.com/KhronosGroup/SPIRV-Tools/blob/master/CMakeLists.txt#L119 ->
${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/utils/update_build_version.py

Doing a set(Python_ADDITIONAL_VERSIONS 2.7 2.6 2.5) right before find_host_package(PythonInterp) makes it properly use python 2.x (I don't know what the minimum python requirement should be here).
Tested this on latest Arch Linux (which defaults to python3 otherwise) and OS X.

from spirv-tools.

Right now the script should run under both Python2 & Python3.

from spirv-tools.