Giter Club home page Giter Club logo

Comments (10)

khoben avatar khoben commented on July 25, 2024 1

Configuring filters through environment vars will be too complicated. The only optimal option is to specify it via yaml/json string, which makes editing not very convenient.

I am not saying to configure filters via environment variables, instead I was saying to put YAML file contents same in one env var, as we need to first import your repo then make it private then setup yaml file. While forking, repo is always public so can't expose YAML config file publically. Also importing restricts us any future commits made to the original repo while forking one does.

You want to put the entire configuration from yaml into single string as environment variable. Okay, I got it.

from telemirror.

khoben avatar khoben commented on July 25, 2024 1

Try running the app locally, also check out the latest version

from telemirror.

chakra1n avatar chakra1n commented on July 25, 2024 1

Try setting YAML_CONFIG_ENV now. I assume you can just copy-paste the yaml file contents through the heroku interface.

Thanks, its working.

ISSUE RESOLVED!!

from telemirror.

khoben avatar khoben commented on July 25, 2024

Could you provide a minimal example and error stacktrace for the bugs found?
The screenshot shows that Heroku expects that the port specified through the PORT variable should be bound to the application, it will be fixed soon.

Configuring filters through environment vars will be too complicated. The only optimal option is to specify it via yaml/json string, which makes editing not very convenient.

from telemirror.

khoben avatar khoben commented on July 25, 2024

@chakra1n Please check if the app is now working on Heroku with the latest commit?

from telemirror.

chakra1n avatar chakra1n commented on July 25, 2024

First two issues are fixed but third one is still there.

Message at Source Side (before editing image)

image

Message at Destination Side (before editing image)

image

This works perfectly fine but check next scenario.

Image edited using telegram official image edit feature

image

Message at Source Side (after editing image)

image

Message at Destination Side (after editing image)

image

Image is not edited and also now app gets crashed

Heroku Logs

image

from telemirror.

chakra1n avatar chakra1n commented on July 25, 2024

Configuring filters through environment vars will be too complicated. The only optimal option is to specify it via yaml/json string, which makes editing not very convenient.

I was not saying to configure filters via environment variables, instead I was saying to put YAML file contents same as it is in a environment variable, as we need to first import your repo then make it private then setup yaml file. While forking, repo is always public so can't expose YAML config file publically. Also importing restricts us any future commits made to the original repo while forking one does.

from telemirror.

khoben avatar khoben commented on July 25, 2024

First two issues are fixed but third one is still there.

Message at Source Side (before editing image)

image

Message at Destination Side (before editing image)

image

This works perfectly fine but check next scenario.

Image edited using telegram official image edit feature

image

Message at Source Side (after editing image)

image

Message at Destination Side (after editing image)

image

Image is not edited and also now app gets crashed

Heroku Logs

image

Just checked replacing and editing images, everything works. Actually, from your logs you have the same problem with heroku port binding.

from telemirror.

chakra1n avatar chakra1n commented on July 25, 2024

Try running the app locally, also check out the latest version

Thanks, its working fine after re-deploying in Heroku. Now web app url is also giving status OK earlier it states Application Error.

You want to put the entire configuration from yaml into single string as environment variable. Okay, I got it

Now, just waiting for this update :)
It will be helpful for other users too who are using Heroku ..

from telemirror.

khoben avatar khoben commented on July 25, 2024

Try setting YAML_CONFIG_ENV now. I assume you can just copy-paste the yaml file contents through the heroku interface.

from telemirror.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.