Exception when file name is null about mimetypes HOT 5 CLOSED

v2.0.2 is now on NuGet 🙌

from mimetypes.

Umm. Good catch! @gfoidl I assume this shouldn't be nullable? 🤔

from mimetypes.

It depends on your design. Usually methods like TrySomething allows nulls. GetMimeType should throw ArgumentNullException for null string (because string supports Null Object Pattern - string.Empty). So I think you should remove ? from method signature.

from mimetypes.

Yeah, @ekisielinski is correct. We should remove the ? when null is validated and an ArgumentNullException thrown, so that the compilers knows that null isn't "tolerated".
For the Try-method null is allowed, so here the ? is correct.

Sorry, that's my fault. My brain was at a preview-stage of nullability and didn't update to the release along the way with updated guidlines on how to annotate...

from mimetypes.

Closed with 5d4e0de

from mimetypes.