Comments (8)
doing the lord's work zachary
from shapecorners.
zzag (the KWin commit author) kindly provided some extra info regarding the relevant changes:
we removed some of kwin's internal rendering abstractions from effects api in 5.23 for optimization purposes and to hide some implementation details so we can change rendering code to better suit wayland world. in case you need window quads, we added the DeformEffect class. however, if you use windowquad::type(), there are no replacements, unfortunately, but there are still ways around it, e.g. constraining painting to the frameGeometry() or clientGeometry()
...
as for rounding corners, kwin devs' stance is that it should be done client-side. on wayland, the compositor simply cannot determine where bottom window corners are
...
besides the wayland issues, we have performance related concerns
Luckily we only target X11 :)
Regarding performance concerns, zzag and I discussed how ShapeCorners handles rendering/window paints. It seems that ShapeCorners perf is fine, at least for now.
I'll attempt to implement zzag's advice and fix my fork :)
from shapecorners.
https://github.com/matinlotfali/KDE-Rounded-Corners seems to get it fixed
from shapecorners.
After updating to KDE neon 5.23.0, ShapeCorners does not work at all. (It was compiled earlier and worked until the KDE neon update.)
Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.0
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.3
Kernel Version: 5.11.0-37-generic (64-bit)
Graphics Platform: X11
Processors: 4 × Intel® Core™ i5-7200U CPU @ 2.50GHz
Memory: 7.7 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 620
from shapecorners.
I can confirm this issue as well. Looking to implement a fix in my fork (since I'm not sure this repo is maintained). Will link if I get something working.
from shapecorners.
This seems to be the relevant, breaking commit in KWin. I've reached out to see if there's a new way of fetching window quads.
from shapecorners.
Thank youuu, I'll work on implementing those changes :)
from shapecorners.
My fork now implements a fix for this issue based off of matinlotfali's code.
Shadows/corner blurs are currently broken (see this issue).
from shapecorners.
Related Issues (11)
- Semi-translucent corners look buggy HOT 2
- Uninstall HOT 3
- Some windows are blurry when running under wayland
- Blacklist by title? Or window type?
- Doesn't works on KDE Neon 5.21
- Doesn't work on Plasma 5.21.2
- Translucent edges HOT 1
- Make "SquareAtScreenEdge" handle multiple monitors HOT 3
- failed to build with KDE's master builds
- Theres no arch install instructions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shapecorners.