Giter Club home page Giter Club logo

Comments (4)

khalyomede avatar khalyomede commented on July 18, 2024

I think this would comes handy, working on it :). Thank you for your time filling an issue.

from opened-closed.

fgerards avatar fgerards commented on July 18, 2024

any scatches on that functionality ?

from opened-closed.

khalyomede avatar khalyomede commented on July 18, 2024

Sorry Franck, got completely absorbed on another side project. Will give it a try this weekend thanks for your patience 🙏

from opened-closed.

khalyomede avatar khalyomede commented on July 18, 2024

After a quick dig into the code, I might need to take a little bit more time to make a refactor:

  1. Currently the openings is a list of days related to hour spans -> I think this is wrong, if you want to have exceptional openings, this is limiting
  2. Closing is a list of time spans -> This is the reverse issue of 1., I should make sure both openings and closings actually supports time spans and day/hour spans
  3. The code is outdated (by basically 2-3 years) -> I would like to bring support for newest Node.Js versions (currently the package only support Node <= 14, newest is 19)
  4. Once I did this, I will be able to refactor the code to avoid working with hand-made date manipulation functions but using a state-of-the-art Date manipulation, I am used to use Carbon for PHP which lifts a lot of burden regarding this kind of task looking for something similar in JS to be able to work with Intervals etc...)

Hope it sounds ok and you're not in a hurry, sorry for the inconvenience!

from opened-closed.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.