Tabindex Refinements about foundry-vtt-tidy-5e-sheets HOT 9 CLOSED

Both the default 5e sheet and the prior incarnation of Tidy 5e sheet used the type=hidden attribute on the fields immediately surrounding the attribute inputs. I can't see a way to force the keyboard tabbing path to follow the same rules without basically doing the same thing. If you try to do it via tabindex you're going to have to set it for everything on the sheet, which is obviously a horrible idea and even then it will probably break the focus order for things outside the sheet. Doing it programmatically will likely result in a similarly horrible outcome.

from foundry-vtt-tidy-5e-sheets.

I agree. I let this issue sit while I worked on a lot of other stuff in the repo, and now that time has passed, I don't think it's worth the trouble, given the level of risk and/or churn it would require.

Ultimately, I would rather those buttons be available when tabbing through than require a mouse click.

I'm strongly considering a wontfix and closure on this issue.

from foundry-vtt-tidy-5e-sheets.

I'd be inclined to keep it as client scoped as it's very much a user preference.

from foundry-vtt-tidy-5e-sheets.

Closing as completed with panache

from foundry-vtt-tidy-5e-sheets.

I'd say that's the safest bet if you wish to keep keyboard input available to the other controls.

from foundry-vtt-tidy-5e-sheets.

There is one other possibility, mind you, which would be to have it as an optional sheet setting toggle. That way if someone turned it on, it could set the fields around to hidden for those that really really wanted it.

from foundry-vtt-tidy-5e-sheets.

I could work up a PR for that if you want?

from foundry-vtt-tidy-5e-sheets.

Yeah, if you'd like to do one up.
I'm wondering where to put such an option. And should it be client- or world-scoped?
I would think it'd span all sheets because it's a general user preference. So maybe on the main config menu (config: true).

from foundry-vtt-tidy-5e-sheets.

The fix for this is slated for the next release in 0-2 days.

from foundry-vtt-tidy-5e-sheets.