Let's migrate to Py3 about house-renting HOT 6 CLOSED

@cclauss you're right, I tried u'strings' and it works, we are closer to Python 3 now!

from house-renting.

https://github.com/kezhenxu94/house-renting/blob/master/crawler/house_renting/items.py#L46-L49 and https://github.com/kezhenxu94/house-renting/blob/master/crawler/house_renting/items.py#L65

In Python 3, you can have a u'string' and an r'string' but a ur'string' is a Syntax Error.

flake8 testing of https://github.com/kezhenxu94/house-renting on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./crawler/house_renting/items.py:46:46: E999 SyntaxError: invalid syntax
    minutes_ago = re.compile(ur'.*?(\d+)分钟前.*').search(value)
                                             ^
1     E999 SyntaxError: invalid syntax
1

from house-renting.

On Python 2, can we try the following?

1. Convert these ur'strings' to r'strings' and see if the code functions as expected and then
2. Convert these ur'strings' to u'strings' and see if the code functions as expected

My guess is that one of these will work as expected and the other will not.

from house-renting.

@cclauss now can we say this project is compatible with Python3 and Python2 ?

from house-renting.

It is syntax compatible with both Python 2 and Python 3. However end users might find bugs that we will need to fix. I think we should say that both Python 2 and Python 3 are now supported. That means that as issues are opened, we will try our best to fix them.

from house-renting.

@cclauss Great. I'll consider closing this issue

from house-renting.