`assertFieldInputs` docs are slightly misleading? about keystone-nightwatch-e2e HOT 4 OPEN

@jstockwin yes, the javadocs for the methods should be updated.

from keystone-nightwatch-e2e.

@webteckie And which way is correct? We're also passing options to the fieldTestObject, so the extra value bit seems unnecessary to me. Will mean every single keystone test needs updating again though, so maybe we keep it as it is and update the docs?

from keystone-nightwatch-e2e.

@jstockwin I ponder this decision a bit and ultimately decided on the existing syntax. My preference is to update the docs but up to you :-)

from keystone-nightwatch-e2e.

Fine with me :)

On Fri, 11 Nov 2016, 12:24 Carlos Colon, [email protected] wrote:

@jstockwin https://github.com/jstockwin I ponder this decision a bit
and ultimately decided on the existing syntax. My preference is to update
the docs but up to you :-)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH2Lrx2SyBiKczphiV4ExBKOlPnoPR8Bks5q9F6WgaJpZM4KvK7q
.

from keystone-nightwatch-e2e.