Command.stdoutpipe fails on GCP Cloud Run about go-keybase-chat-bot HOT 4 OPEN

Yep I confirmed the fix, switching from StdoutPipe and StderrPipe to a custom os.Pipe() solved the output issues when in google cloud run.

I had to change the pipes in func getUsername, func (a *API) startPipes() and func (a *API) Listen and it worked out great.

Fix in my fork:
https://github.com/malware-unicorn/go-keybase-chat-bot/blob/master/kbchat/kbchat.go#L37

Also os.Pipe does not work in Windows environments so there might need to be a better work around in the future.

from go-keybase-chat-bot.

@malware-unicorn calling Run on the command blocks until completion, defeating the timeout in play later in the function https://github.com/malware-unicorn/go-keybase-chat-bot/blob/master/kbchat/kbchat.go#L48. In #57 I added the output pipe to ExtraFiles, are you able to get the command running with these fixes?

from go-keybase-chat-bot.

@joshblum yeah the Run is not needed but what is needed is the actual assignment for stdout because the command needs a different file descriptor since the container's stdout file descriptor is being locked/used by google cloud run's logging.

pipeR, pipeW, _ := os.Pipe()
	p.Stdout = pipeW <-------This is needed
	p.ExtraFiles = []*os.File{
		pipeW,
	}

and

scanner := bufio.NewScanner(pipeR)

Anywhere StdoutPipe is called would need to be changed to p.Stdout = pipeW

from go-keybase-chat-bot.

@malware-unicorn calling StdoutPipe creates a pipe, it doesn't use os.Stdout so our changes should be equivalent with the ExtraFiles call https://golang.org/src/os/exec/exec.go?s=17635:17684#L604

from go-keybase-chat-bot.